Skip to content

Add in check for _BPXK_AUTOCVT and set if not set (fail if set to OFF)#597

Merged
MikeFultonDev merged 2 commits intomainfrom
fixcfgundersh
Nov 24, 2023
Merged

Add in check for _BPXK_AUTOCVT and set if not set (fail if set to OFF)#597
MikeFultonDev merged 2 commits intomainfrom
fixcfgundersh

Conversation

@MikeFultonDev
Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev commented Nov 24, 2023

Ran metaport manually. All good:

- Integration complete
- Sourcing environment to run any setup
Setting up meta...
Setup completed.

@MikeFultonDev MikeFultonDev added the bug Something isn't working label Nov 24, 2023
@MikeFultonDev MikeFultonDev self-assigned this Nov 24, 2023
IgorTodorovskiIBM
IgorTodorovskiIBM approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeFultonDev
Copy link
Copy Markdown
Collaborator Author

MikeFultonDev commented Nov 24, 2023

/run tests

DevonianTeuchter
DevonianTeuchter approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@DevonianTeuchter DevonianTeuchter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor nit that there's a missing full-stop at the end of the message that some folks might like :-)

@MikeFultonDev MikeFultonDev merged commit 665b23e into main Nov 24, 2023
@MikeFultonDev MikeFultonDev deleted the fixcfgundersh branch November 24, 2023 19:23
@MikeFultonDev
Copy link
Copy Markdown
Collaborator Author

MikeFultonDev commented Nov 24, 2023

LGTM - minor nit that there's a missing full-stop at the end of the message that some folks might like :-)

ah! sorry - didn't see this until now. will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgorTodorovskiIBM IgorTodorovskiIBM IgorTodorovskiIBM approved these changes

@DevonianTeuchter DevonianTeuchter DevonianTeuchter approved these changes

@HarithaIBM HarithaIBM Awaiting requested review from HarithaIBM HarithaIBM is a code owner

Assignees

@MikeFultonDev MikeFultonDev

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikeFultonDev @IgorTodorovskiIBM @DevonianTeuchter