Fix date to timestamp conversion#649
Merged
IgorTodorovskiIBM merged 2 commits intomainfrom Jan 17, 2024
Merged
Conversation
HarithaIBM
approved these changes
Jan 5, 2024
AnthonyGiorgio
requested changes
Jan 5, 2024
MikeFultonDev
approved these changes
Jan 17, 2024
Collaborator
MikeFultonDev
left a comment
There was a problem hiding this comment.
This is fine but can you create another issue so that we can pick up fixes to date/sha256sum if they are required as part of the build process of meta?
Member
Author
Will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
Another approach would be to embed coreutils (which includes date, sha256sum and many other tools). Another benefit of this is that we don't have to rely ascii workarounds like asciiecho (https://github.com/ZOSOpenTools/meta/blob/main/bin/zopen-build#L40) and we also can replace numcpus.rexx with
nproc. It will increase size by 14mbs though.