Skip to content

Fix date to timestamp conversion#649

Merged
IgorTodorovskiIBM merged 2 commits intomainfrom
fix_analytics
Jan 17, 2024
Merged

Fix date to timestamp conversion#649
IgorTodorovskiIBM merged 2 commits intomainfrom
fix_analytics

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

  • Fixes the issue in processAnalyticsFromLogFile as reported by @AnthonyGiorgio by embedding date into utilities:
parse error: Invalid numeric literal at line 1, column 10
FSUM9364 Bad date conversion: 2023-10-06 10:42:29
Usage: date [-cu] [-d time] [+format]
  • Also embeds sha256sum, which would be used to verify the checksum matches the metadata.json's checksum

Note:
Another approach would be to embed coreutils (which includes date, sha256sum and many other tools). Another benefit of this is that we don't have to rely ascii workarounds like asciiecho (https://github.com/ZOSOpenTools/meta/blob/main/bin/zopen-build#L40) and we also can replace numcpus.rexx with nproc. It will increase size by 14mbs though.

Comment thread include/analytics.sh Outdated
Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but can you create another issue so that we can pick up fixes to date/sha256sum if they are required as part of the build process of meta?

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

This is fine but can you create another issue so that we can pick up fixes to date/sha256sum if they are required as part of the build process of meta?

Will do

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit b7c43bd into main Jan 17, 2024
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the fix_analytics branch January 17, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants