Skip to content

Remove temporary gpg files after successful verification + message updates#940

Merged
IgorTodorovskiIBM merged 4 commits intomainfrom
gpg_tmp_file_removal
Jan 9, 2025
Merged

Remove temporary gpg files after successful verification + message updates#940
IgorTodorovskiIBM merged 4 commits intomainfrom
gpg_tmp_file_removal

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

@IgorTodorovskiIBM IgorTodorovskiIBM commented Jan 9, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Content Update

Category

  • zopen build framework
  • zopen package manager
  • Documentation
  • CI/CD
  • Tools

Description

After a successful verification, due to the return 0 in https://github.com/zopencommunity/meta/compare/gpg_tmp_file_removal?expand=1#diff-c43bdd799ba8da6fcee24cd51eb2283d29922a616b6174ecdf43b458fc0a155cL87, files were not being cleaned up. Also, I was getting an scdaemon issue on plpsc so I have disabled that since it's not needed.
I also added a prefix of zopen_ to the public and signature files.
I have also reduced the verbosity of zopen by default. In the event of a gpg error, the gpg command output will be emitted.

Related Issues

[optional] Are there any post-deployment tasks or follow-up actions required?

@IgorTodorovskiIBM IgorTodorovskiIBM changed the title Remove temporary gpg files after successful verification Remove temporary gpg files after successful verification + message updates Jan 9, 2025
Copy link
Copy Markdown
Collaborator

@DevonianTeuchter DevonianTeuchter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The line 92 test could be negated to allow processing to get to the now redundant code on lines 105-107 to return the 0, but that's a minor nit.

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

IgorTodorovskiIBM commented Jan 9, 2025

LGTM. The line 92 test could be negated to allow processing to get to the now redundant code on lines 105-107 to return the 0, but that's a minor nit.

Thanks, I made a few more updates. I also noticed that printInfo is redirecting to stderr. I changed it to print to stdout, but let me know if there was a reason for printing to stderr.


I suppose printHeader, printVerbose, and printAttention would also need updating

Note: This change will require a corresponding update to the tests in metaport. I can leave it for another PR so as not to block this one.

Copy link
Copy Markdown
Member

@HarithaIBM HarithaIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@DevonianTeuchter DevonianTeuchter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The redirect of printInfo appears to be something that was lost a long time ago - can't remember there being a reason for it not to behave like the others!

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

I've updated the tests, so if there's no issues, I'll merge it

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 1870fd2 into main Jan 9, 2025
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the gpg_tmp_file_removal branch January 9, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants