Remove temporary gpg files after successful verification + message updates#940
Remove temporary gpg files after successful verification + message updates#940IgorTodorovskiIBM merged 4 commits intomainfrom
Conversation
…or on verbose output
DevonianTeuchter
left a comment
There was a problem hiding this comment.
LGTM.
The line 92 test could be negated to allow processing to get to the now redundant code on lines 105-107 to return the 0, but that's a minor nit.
Thanks, I made a few more updates. I also noticed that I suppose printHeader, printVerbose, and printAttention would also need updating Note: This change will require a corresponding update to the tests in metaport. I can leave it for another PR so as not to block this one. |
DevonianTeuchter
left a comment
There was a problem hiding this comment.
LGTM
The redirect of printInfo appears to be something that was lost a long time ago - can't remember there being a reason for it not to behave like the others!
|
I've updated the tests, so if there's no issues, I'll merge it |
What type of PR is this? (check all applicable)
Category
Description
After a successful verification, due to the return 0 in https://github.com/zopencommunity/meta/compare/gpg_tmp_file_removal?expand=1#diff-c43bdd799ba8da6fcee24cd51eb2283d29922a616b6174ecdf43b458fc0a155cL87, files were not being cleaned up. Also, I was getting an scdaemon issue on plpsc so I have disabled that since it's not needed.
I also added a prefix of
zopen_to the public and signature files.I have also reduced the verbosity of zopen by default. In the event of a gpg error, the gpg command output will be emitted.
Related Issues
zopen upgradewhengpg-agentis already running #939 (does not directly fix it)[optional] Are there any post-deployment tasks or follow-up actions required?