Conversation
…te. Will likely edit in the future.
zorn
commented
May 4, 2026
Comment on lines
+9
to
+15
| force_ssl: [ | ||
| rewrite_on: [:x_forwarded_proto], | ||
| exclude: [ | ||
| # paths: ["/health"], | ||
| hosts: ["localhost", "127.0.0.1"] | ||
| ] | ||
| ], |
Owner
Author
There was a problem hiding this comment.
I'm concerned this might not work in production based on the past commented-out part, but we will see.
There was a problem hiding this comment.
Pull request overview
Updates Flick’s dependencies and aligns the codebase with Phoenix 1.8 project template conventions, including Tailwind v4 and Phoenix Storybook v1, plus a layout refactor to the new <Layouts.app ...> pattern.
Changes:
- Bump core deps (Phoenix 1.8, LiveView, Storybook 1.0, etc.) and adjust app configuration accordingly.
- Migrate Tailwind configuration to v4 CSS-first setup (remove
tailwind.config.js, adjust asset build outputs/paths). - Refactor LiveView rendering to wrap content with
Layouts.appand move the app layout implementation intoFlickWeb.Layouts.
Reviewed changes
Copilot reviewed 41 out of 45 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/flick_web/controllers/error_html_test.exs | Narrow Phoenix.Template import to render_to_string/4. |
| storybook/welcome.story.exs | Update Storybook welcome page markup/classes for new template/styles. |
| storybook/examples/core_components.story.exs | Simplify Storybook example UI and form flow. |
| storybook/core_components/table.story.exs | Rename module/structure and expand variations to match new Storybook conventions. |
| storybook/core_components/list.story.exs | Rename module and adjust template/slot examples. |
| storybook/core_components/input.story.exs | Rename module, restructure variations, update template wrapper. |
| storybook/core_components/icon.story.exs | Add new Storybook story for the icon component. |
| storybook/core_components/header.story.exs | Rename module and update variations/descriptions. |
| storybook/core_components/flash.story.exs | Rename module and update template/variations. |
| storybook/core_components/error.story.exs | Add new Storybook story for the error component. |
| storybook/core_components/button.story.exs | Rename module and update button variations. |
| storybook/core_components/back.story.exs | Add new Storybook story for the back component. |
| storybook/core_components/_core_components.index.exs | Add Storybook index entries/icons for core components. |
| storybook/_root.index.exs | Update Storybook root index icon styling/class. |
| mix.lock | Lock updated dependency set (Phoenix 1.8, LiveView 1.1, Storybook 1.0, Tailwind mix task, etc.). |
| mix.exs | Update deps, add LiveView compiler/listener config, add precommit alias. |
| lib/flick/ranked_voting/vote.ex | Minor refactor using Enum.empty?/1 for invalid-answer check. |
| lib/flick/application.ex | Remove Finch supervision child (switching to Req for Swoosh API client). |
| lib/flick_web/storybook.ex | Update Storybook OTP app + sandbox class, and Storybook backend module config. |
| lib/flick_web/router.ex | Update Storybook route backend module reference. |
| lib/flick_web/live/vote/vote_capture_live.ex | Wrap page content in Layouts.app. |
| lib/flick_web/live/vote/results_live.ex | Wrap page content in Layouts.app. |
| lib/flick_web/live/index_live.ex | Wrap page content in Layouts.app. |
| lib/flick_web/live/ballots/viewer_live.ex | Wrap page content in Layouts.app across render clauses. |
| lib/flick_web/live/ballots/index_live.ex | Wrap admin index page content in Layouts.app. |
| lib/flick_web/live/ballots/editor_live.ex | Wrap editor form page content in Layouts.app. |
| lib/flick_web/endpoint.ex | Update Plug.Static settings (gzip + missing file behavior) per newer template. |
| lib/flick_web/components/layouts/root.html.heex | Update asset paths and body class; simplify <html> tag. |
| lib/flick_web/components/layouts/app.html.heex | Remove old app layout template file (moved into Layouts.app/1). |
| lib/flick_web/components/layouts.ex | Add Layouts.app/1 function component and module docs/attrs/slots. |
| lib/flick_web.ex | Remove default controller/live_view layout config and alias Layouts for templates. |
| config/test.exs | Enable LiveView runtime checks + verified routes query param sorting. |
| config/runtime.exs | Centralize http port configuration; adjust prod endpoint config comments. |
| config/prod.exs | Enable force_ssl and switch Swoosh API client to Req. |
| config/dev.exs | Update endpoint http config, live_reload patterns, and logger formatter config; expand LV debug options. |
| config/config.exs | Update esbuild + Tailwind versions and adjust asset build output paths. |
| assets/vendor/topbar.js | Update vendored topbar to 3.0.0 and tweak canvas insertion timing. |
| assets/vendor/heroicons.js | Add Tailwind plugin module for embedding Heroicons via CSS plugin directive. |
| assets/tsconfig.json | Add editor TS config for LiveView JS autocompletion. |
| assets/tailwind.config.js | Remove Tailwind v3 config (moving to Tailwind v4 CSS-first). |
| assets/js/app.js | Add colocated hooks integration and dev live_reload QoL features; minor JS modernization. |
| assets/css/storybook.css | Update Tailwind v4 import + sources for Storybook stylesheet. |
| assets/css/app.css | Migrate to Tailwind v4 CSS-first config (@import, @plugin, @source, variants). |
| AGENTS.md | Add project contribution guidelines aligned with Phoenix 1.8 + Tailwind v4. |
| .gitignore | Ignore ElixirLS artifacts (/.elixir_ls/). |
Comments suppressed due to low confidence (1)
mix.exs:103
- The
:tailwindrequirement is still~> 0.2, butmix.lockpinstailwindto0.4.1. This constraint mismatch will fail dependency resolution; update the:tailwindrequirement to allow0.4.x(or regeneratemix.lockto a compatible version).
{:postgrex, ">= 0.0.0"},
{:swoosh, "~> 1.5"},
{:tailwind, "~> 0.2", runtime: Mix.env() == :dev},
{:telemetry_metrics, "~> 1.0"},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ld miss the configured port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
flokiNotes
lib/flick_web/components/core_components.exfile since it relies on Daisy UI and I am not adding that.