Skip to content

Read Aloud: Indicate skip granularity on buttons #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbeJellinek wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Read Aloud: Indicate skip granularity on buttons #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f6609d
Read Aloud: Indicate skip granularity on buttons
AbeJellinek Mar 9, 2026
11c19b9
Indicate granularity in tooltip
AbeJellinek Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions res/icons/20/skip-ahead-granular.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions res/icons/20/skip-back-granular.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
29 changes: 24 additions & 5 deletions src/common/components/utility-popup/read-aloud-popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import IconSkipBack from '../../../../res/icons/20/skip-back.svg';
import IconPlay from '../../../../res/icons/20/play.svg';
import IconPause from '../../../../res/icons/20/pause.svg';
import IconSkipAhead from '../../../../res/icons/20/skip-ahead.svg';
import IconSkipBackGranular from '../../../../res/icons/20/skip-back-granular.svg';
import IconSkipAheadGranular from '../../../../res/icons/20/skip-ahead-granular.svg';
import IconAnnotate from '../../../../res/icons/20/read-aloud-annotate.svg';
import IconLoading from '../../../../res/icons/16/loading.svg';
import IconClock from '../../../../res/icons/12/clock.svg';
Expand Down Expand Up @@ -461,6 +463,19 @@ function PlaybackControls(props) {
const { l10n } = useLocalization();

let { showOptions, onToggleOptions, showSpinner, paused, onPlayPause, controller, onAddAnnotation, onLockPosition } = props;
let [altDown, setAltDown] = useState(false);

useEffect(() => {
let handleKey = (event) => {
setAltDown(event.altKey);
};
window.addEventListener('keydown', handleKey);
window.addEventListener('keyup', handleKey);
return () => {
window.removeEventListener('keydown', handleKey);
window.removeEventListener('keyup', handleKey);
};
}, []);

function handleAddAnnotation() {
let segment = controller?.getSegmentToAnnotate();
Expand All @@ -470,7 +485,11 @@ function PlaybackControls(props) {
}

return (
<div className="row buttons" data-tabstop={1}>
<div
className="row buttons"
data-tabstop={1}
onMouseMove={event => setAltDown(event.altKey)}
>
<div className="group">
<button
className={cx('toolbar-button', { active: showOptions })}
Expand All @@ -482,13 +501,13 @@ function PlaybackControls(props) {
<div className="group">
<button
className="toolbar-button"
title={l10n.getString('reader-read-aloud-skip-back')}
title={l10n.getString(altDown ? 'reader-read-aloud-skip-back-sentence' : 'reader-read-aloud-skip-back')}
tabIndex="-1"
onClick={(event) => {
controller?.skipBack(event.altKey ? 'sentence' : 'paragraph', event.shiftKey);
onLockPosition();
}}
><IconSkipBack/></button>
>{altDown ? <IconSkipBackGranular/> : <IconSkipBack/>}</button>
{showSpinner
? <IconLoading
className="loading-spinner"
Expand All @@ -508,13 +527,13 @@ function PlaybackControls(props) {
}
<button
className="toolbar-button"
title={l10n.getString('reader-read-aloud-skip-ahead')}
title={l10n.getString(altDown ? 'reader-read-aloud-skip-ahead-sentence' : 'reader-read-aloud-skip-ahead')}
tabIndex="-1"
onClick={(event) => {
controller?.skipAhead(event.altKey ? 'sentence' : 'paragraph', event.shiftKey);
onLockPosition();
}}
><IconSkipAhead/></button>
>{altDown ? <IconSkipAheadGranular/> : <IconSkipAhead/>}</button>
</div>
<div className="group">
<button
Expand Down
Loading