Skip to content

TransformService defects #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2019
Merged

TransformService defects #286

merged 6 commits into from
Apr 25, 2019

Conversation

@ilkinabdullayev
Copy link
Contributor

@ilkinabdullayev ilkinabdullayev commented Apr 12, 2019 •
edited
Loading

This PR cover the defects about TransformService.

  1. ServiceType.All was considered as a case when client don't use ServiceType.UI,ServiceType.API or ServiceType.WS.
  2. When the URL path was containing also query part (e.g. service/login.do?action=secure) the query part was lost during the URL transformation. Now it is kept.
  3. When serviceUrl is "/", all slashes were removed from the path. Now the replacing process is skipped when serviceUrl is "/".

@ghost ghost assigned ilkinabdullayev Apr 12, 2019
@ghost ghost added the review label Apr 12, 2019
@ilkinabdullayev ilkinabdullayev force-pushed the defect/transform-service branch from fbacc1b to d18219a Compare April 12, 2019 12:33
@codecov
Copy link

codecov bot commented Apr 12, 2019 •
edited
Loading

Codecov Report

Merging #286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #286   +/-   ##
========================================
  Coverage      67.2%   67.2%           
  Complexity       12      12           
========================================
  Files           206     206           
  Lines          3955    3955           
  Branches        534     534           
========================================
  Hits           2658    2658           
  Misses         1162    1162           
  Partials        135     135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86358e3...2a88f07. Read the comment docs.

@ghost ghost assigned taban03 Apr 12, 2019
@taban03 taban03 mentioned this pull request Apr 12, 2019
Merged
@JirkaAichler JirkaAichler self-requested a review April 12, 2019 13:48
@ilkinabdullayev ilkinabdullayev force-pushed the defect/transform-service branch from 712995b to b2c9768 Compare April 12, 2019 13:49
@taban03 @ilkinabdullayev
defect:Fix probem in TransformService which was removing query part f…
72ccbbe 
…rom path after transformation

Signed-off-by: Andrea Tabone <andrea.tabone@ca.com>
@ilkinabdullayev ilkinabdullayev force-pushed the defect/transform-service branch from b2c9768 to 72ccbbe Compare April 12, 2019 14:01
@JirkaAichler
Copy link
Contributor

Please fix also bug when serviceUrl = "/". Thanks!

@ilkinabdullayev ilkinabdullayev force-pushed the defect/transform-service branch from 4bf38a8 to a3b8f74 Compare April 15, 2019 12:03
@ilkinabdullayev ilkinabdullayev force-pushed the defect/transform-service branch from a3b8f74 to 25999b4 Compare April 15, 2019 12:08
@ilkinabdullayev ilkinabdullayev requested a review from taban03 April 16, 2019 08:24
taban03
taban03 previously approved these changes Apr 16, 2019
View reviewed changes
JirkaAichler
JirkaAichler reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I will approve once it passes integration tests.

@petr-galik petr-galik requested a review from arxioly April 23, 2019 12:14
JirkaAichler
JirkaAichler approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ilkin!

@arxioly arxioly self-requested a review April 25, 2019 10:19
arxioly
arxioly approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@arxioly arxioly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks!

@ilkinabdullayev ilkinabdullayev merged commit 17420fb into master Apr 25, 2019
@ghost ghost removed the review label Apr 25, 2019
ilkinabdullayev pushed a commit that referenced this pull request Apr 25, 2019
@ilkinabdullayev
TransformService defects (#286)
54cf1e0 
* defect: ServiceType.All is fixed

* defect:Fix  probem in TransformService which was removing query part from path after transformation

Signed-off-by: Andrea Tabone <andrea.tabone@ca.com>

* defect: Fixed serviceUrl is '/' case

* Covered NPE case in serviceUriPath
@taban03 taban03 deleted the defect/transform-service branch May 15, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arxioly arxioly arxioly approved these changes

@JirkaAichler JirkaAichler JirkaAichler approved these changes

@taban03 taban03 taban03 left review comments

Assignees

@ilkinabdullayev ilkinabdullayev

@taban03 taban03

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ilkinabdullayev @JirkaAichler @arxioly @taban03 @zowe-robot