Skip to content

Conversation

@pketki
Copy link
Contributor

@pketki pketki commented Oct 30, 2025

Description

In the nodejs-enabler index, we initialize pulling tls options from a config file that can be optionally sent as a JSON. This also expects files to only be PEMs and doesn't support PKCS#12. Since we now expose the client directly we should make reading the TLS also conditional.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pketki pketki requested a review from achmelo October 30, 2025 18:56
@pketki pketki changed the title Initialize client only if config files exist refactor (enabler-nodejs): Initialize client only if config files exist Oct 30, 2025
Signed-off-by: pketki <ketki.purandare23@gmail.com>
@pketki pketki force-pushed the pketki/nodejs-enabler-initialize-client-conditionally branch from 2eb6f98 to 1633c94 Compare October 30, 2025 19:00
@sonarqubecloud
Copy link

@achmelo achmelo merged commit 22b9e46 into v3.x.x Oct 31, 2025
38 checks passed
@achmelo achmelo deleted the pketki/nodejs-enabler-initialize-client-conditionally branch October 31, 2025 08:30
Goutham024 pushed a commit to Joe-Winchester/api-layer-OIDC-POC that referenced this pull request Nov 6, 2025
…st (zowe#4370)

Signed-off-by: pketki <ketki.purandare23@gmail.com>
Signed-off-by: Gowtham Selvaraj <Gowtham.Selvaraj1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants