Skip to content

Conversation

@taban03
Copy link
Contributor

@taban03 taban03 commented Nov 3, 2025

Description

Add validation to check whether a service ID is conformant. That means that it must comply with RFC 952 and RFC 1123 - only lowercase letters, digits and hyphens allowed, must not start or end with a hyphen, and must not exceed 63 characters.
Add same validation to the java enabler
Add also a check for instance ID to ensure the correct format hostname:serviceid:port

Fix to #3844
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 3, 2025
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03 taban03 marked this pull request as ready for review November 3, 2025 15:32
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03 taban03 changed the title fix: add serviceid validation fix: add service ID validation Nov 3, 2025
taban03 and others added 4 commits November 4, 2025 14:12
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
taban03 and others added 6 commits November 4, 2025 16:35
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@EvaJavornicka EvaJavornicka moved this from New to In Progress in API Mediation Layer Backlog Management Nov 5, 2025
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
taban03 and others added 2 commits November 5, 2025 14:14
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@taban03 taban03 merged commit ec4000c into v3.x.x Nov 5, 2025
38 checks passed
@taban03 taban03 deleted the reboot/gh3844/fix_serviceid_validation branch November 5, 2025 14:28
Goutham024 pushed a commit to Joe-Winchester/api-layer-OIDC-POC that referenced this pull request Nov 6, 2025
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Signed-off-by: Gowtham Selvaraj <Gowtham.Selvaraj1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

3 participants