Skip to content

fix: correctly propagate the apiml.debug property in start.sh#4540

Merged
taban03 merged 2 commits into
v3.x.xfrom
reboot/fix_apiml_debug
Apr 8, 2026
Merged

fix: correctly propagate the apiml.debug property in start.sh#4540
taban03 merged 2 commits into
v3.x.xfrom
reboot/fix_apiml_debug

Conversation

@taban03
Copy link
Copy Markdown
Contributor

@taban03 taban03 commented Apr 7, 2026

Description

Correctly propagate the apiml.debug property into the start.sh so it will be used.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Copy link
Copy Markdown
Contributor

@pablocarle pablocarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, just please make sure there's no conflict with defaults in manifest files or defaults.yml in zowe-install-packaging

Comment thread apiml-package/src/main/resources/bin/start.sh Outdated
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
@taban03
Copy link
Copy Markdown
Contributor Author

taban03 commented Apr 7, 2026

It's ok, just please make sure there's no conflict with defaults in manifest files or defaults.yml in zowe-install-packaging

It's ok, just please make sure there's no conflict with defaults in manifest files or defaults.yml in zowe-install-packaging

I've checked, the default value is still the same and it's fault in both places, so there shouldn't be any conflict.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

@taban03 taban03 merged commit fd34334 into v3.x.x Apr 8, 2026
78 of 84 checks passed
@taban03 taban03 deleted the reboot/fix_apiml_debug branch April 8, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

2 participants