Skip to content

Provide the Swagger URL for zOSMF #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 25, 2020
Merged

Provide the Swagger URL for zOSMF #800

merged 13 commits into from
Aug 25, 2020

Conversation

@balhar-jakub
Copy link
Member

@balhar-jakub balhar-jakub commented Aug 24, 2020 •
edited
Loading

Description

If the zOSMF doesn't contain APARs with the SwaggerURL show at least the URL towards the service.
Also add ibmzosmf static service as the default one in the catalogue and remove zosmf from the catalogue to prevent user confusion but keep working for the M2M communication

Fixes #665

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

balhar-jakub and others added 11 commits August 25, 2020 07:07
@balhar-jakub
Properly ignore null in base path
8a71912 
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Fix invalid enums in zOSMF Swagger
5a6dbe7 
To be removed once fixed on the zOSMF side

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Add Swagger documentation to the Sample
cdb207e 
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Provide valid Swagger URL when it's present
eec6746 
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Properly handle the zOSMF failure modes to provide the Swagger consum…
40b98b2 
…able by API Doc

Properly ignore swaggerURL in the case of zOS 2.2,2.3 without relevant APARs applied

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Update description to contain at least the URL in case Swagger isn't …
1180a26 
…available

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Adapt changelog to the new requirements for structure and content. (#798
fe8645b 
)

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>

Co-authored-by: Jakub Balhar <jakub.balhar@broadcom.com>
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@jandadav @balhar-jakub
Handle zosmf SID with saf auth (#799)
7bc2e16 
* restrict validation for zosmf only
* clean unused parameters

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Provide path through new service id
e4f5228 
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub
Fix style issues
464bb9a 
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@taban03 @balhar-jakub
Fix problem in error handling when no api-doc is available (#801)
e0811f3 
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub balhar-jakub force-pushed the rip/GH665/provide-zosmf-swagger branch from 03021ff to e0811f3 Compare August 25, 2020 05:07
@balhar-jakub
No regex needed so use just replace
a356c0e 
Test success and fail walkthrough

Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@balhar-jakub balhar-jakub self-assigned this Aug 25, 2020
@balhar-jakub balhar-jakub requested a review from taban03 August 25, 2020 06:37
@balhar-jakub balhar-jakub merged commit 4f5f244 into master Aug 25, 2020
@balhar-jakub balhar-jakub deleted the rip/GH665/provide-zosmf-swagger branch August 25, 2020 07:08
@balhar-jakub balhar-jakub mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taban03 taban03 taban03 approved these changes

@jandadav jandadav Awaiting requested review from jandadav

@jordanCain jordanCain Awaiting requested review from jordanCain

Assignees

@balhar-jakub balhar-jakub

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to find at which URL I can access z/OSMF via Zowe?

5 participants

@balhar-jakub @taban03 @zowe-robot @jandadav