Skip to content

Conversation

@taban03
Copy link
Contributor

@taban03 taban03 commented Aug 24, 2020

Signed-off-by: at670475 andrea.tabone@broadcom.com

Description

If the api doc was not retrieved for some reason and was null, a 200 HTTP status code was returned without any clear message. Instead now an API message is returned with 500 return code.
Fixes #571

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: at670475 <andrea.tabone@broadcom.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@balhar-jakub balhar-jakub merged commit 571127f into master Aug 25, 2020
balhar-jakub pushed a commit that referenced this pull request Aug 25, 2020
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
@balhar-jakub balhar-jakub deleted the rip/GH571/fix_apidoc_error_handling branch August 25, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catalog returns 200 without body

4 participants