Conversation
Collaborator
nojaf
commented
Jul 26, 2025
- Sync changes of main
- Update to ReScript 12 beta 3
* changelog * basic bindings for SQLite * changelog
* feat: bun redis bindings * fix: resolve unit test * fix: resolve playground tests
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zth
reviewed
Jul 26, 2025
test/Shell.test.res
Outdated
| describe("shell", () => { | ||
| testAsync("basic commands work", async () => { | ||
| let res = await (sh`echo "HELLO"`) | ||
| let res = await (sh`echo HELLO`) |
Collaborator
Author
There was a problem hiding this comment.
Got
$ bun test test/*.test.js
bun test v1.2.19 (aad3abea)
test/Shell.test.js:
"HELLO"
4 | import * as Buntest from "bun:test";
5 |
6 | Buntest.describe("shell", () => {
7 | Buntest.test("basic commands work", async () => {
8 | let res = await $$Bun.$`echo \"HELLO\"`;
9 | Buntest.expect(res.stdout.toString()).toBe("HELLO\n");
^
error: expect(received).toBe(expected)
Expected: "HELLO\n"
Received: "\"HELLO\"\n"
at <anonymous> (/Users/nojaf/Projects/rescript-bun/test/Shell.test.js:9:43)
✗ shell > basic commands work [1.74ms]
lib/bs/test/Shell.test.js:
"HELLO"
4 | import * as Buntest from "bun:test";
5 |
6 | Buntest.describe("shell", () => {
7 | Buntest.test("basic commands work", async () => {
8 | let res = await $$Bun.$`echo \"HELLO\"`;
9 | Buntest.expect(res.stdout.toString()).toBe("HELLO\n");
^
error: expect(received).toBe(expected)
Expected: "HELLO\n"
Received: "\"HELLO\"\n"
at <anonymous> (/Users/nojaf/Projects/rescript-bun/lib/bs/test/Shell.test.js:9:43)
✗ shell > basic commands work [0.39ms]
0 pass
2 fail
2 expect() calls
Ran 2 tests across 2 files. [13.00ms]
error: script "test" exited with code 1
without this change.
Owner
There was a problem hiding this comment.
Hmm. This smells like it might be a problem, that " is escaped in the output... I guess maybe a v12 problem? IIRC there was some change around this a little while back, the escaping of (tagged) template literals.
Owner
There was a problem hiding this comment.
rescript-lang/rescript#7196 not sure what that means for this, but we can merge this since you reverted the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.