Skip to content

Conversation

@zth
Copy link
Owner

@zth zth commented Jan 30, 2026

Note

Low Risk
Small, localized change to variable-sanitization logic with added unit coverage; primary risk is subtle regressions in option/sentinel detection for refetch variables.

Overview
Fixes a bug in internal_removeUndefinedAndConvertNullsRaw where detecting Some(None) via value == Some(None) could mis-handle values like empty arrays during refetch variable cleaning.

The function now explicitly detects ReScript’s Some(None) sentinel (BS_PRIVATE_NESTED_SOME_NONE) and only converts that case to null, while continuing to drop None/undefined fields and leaving arrays (including empty arrays) intact. Adds a Jest test covering empty-array preservation and basic dropping/keeping behavior, and documents the fix in CHANGELOG.md.

Written by Cursor Bugbot for commit 1970c9c. This will update automatically on new commits. Configure here.

@zth zth merged commit dfd9b70 into master Jan 30, 2026
7 checks passed
@zth zth deleted the fix-refetch-empty-array branch January 30, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant