Fix refetch empty array #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, localized change to variable-sanitization logic with added unit coverage; primary risk is subtle regressions in option/sentinel detection for refetch variables.
Overview
Fixes a bug in
internal_removeUndefinedAndConvertNullsRawwhere detectingSome(None)viavalue == Some(None)could mis-handle values like empty arrays during refetch variable cleaning.The function now explicitly detects ReScript’s
Some(None)sentinel (BS_PRIVATE_NESTED_SOME_NONE) and only converts that case tonull, while continuing to dropNone/undefinedfields and leaving arrays (including empty arrays) intact. Adds a Jest test covering empty-array preservation and basic dropping/keeping behavior, and documents the fix inCHANGELOG.md.Written by Cursor Bugbot for commit 1970c9c. This will update automatically on new commits. Configure here.