-
-
Notifications
You must be signed in to change notification settings - Fork 398
Initialize CLI interface for python-zulip-api. #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51cf026 to
2cd69cc
Compare
|
This is cool! I think it'd really helpful to have a README (that perhaps we can then port into the /api documentation) with a handful of examples. (I imagine it mostly self-documents with |
|
@timabbott rebased, and used |
|
Merged, thanks @rht! We'll want to do a bit more playing with this and then add it to the documentation. @PIG208 @LoopThrough-i-j @showell are any of you up for spending some time playing with this, perhaps live-blogging the experience in #integrations? |
| logging.basicConfig(stream=sys.stdout, level=logging.INFO) | ||
| log = logging.getLogger("zulip-cli") | ||
|
|
||
| client = zulip.Client(config_file="~/zuliprc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a poor location for a config file, especially since it can’t be overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure the best way to handle this. There is already
| def exit_gracefully_if_zulip_config_is_missing(config_file: Optional[str]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just add the argparse logic from the core library for how to find a zuliprc file.
No description provided.