Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented Mar 6, 2021

No description provided.

@rht rht force-pushed the zulip-cli branch 5 times, most recently from 51cf026 to 2cd69cc Compare March 7, 2021 02:46
@timabbott
Copy link
Member

This is cool! I think it'd really helpful to have a README (that perhaps we can then port into the /api documentation) with a handful of examples. (I imagine it mostly self-documents with --help?)

@rht
Copy link
Contributor Author

rht commented May 15, 2021

@timabbott rebased, and used get_subscriptions instead of list_subscriptions.

@timabbott timabbott merged commit 06bbfd7 into zulip:master May 24, 2021
@timabbott
Copy link
Member

Merged, thanks @rht! We'll want to do a bit more playing with this and then add it to the documentation.

@PIG208 @LoopThrough-i-j @showell are any of you up for spending some time playing with this, perhaps live-blogging the experience in #integrations?

logging.basicConfig(stream=sys.stdout, level=logging.INFO)
log = logging.getLogger("zulip-cli")

client = zulip.Client(config_file="~/zuliprc")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a poor location for a config file, especially since it can’t be overridden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the best way to handle this. There is already

def exit_gracefully_if_zulip_config_is_missing(config_file: Optional[str]) -> None:
, but it's buried down inside zulip_bots. Should we move it to zulip library instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just add the argparse logic from the core library for how to find a zuliprc file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants