Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented May 24, 2022

This fixes #754.

@zulipbot
Copy link
Member

Hello @rht, it seems like you have referenced #754 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #754..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

@timabbott timabbott merged commit 31365a8 into zulip:main May 24, 2022
@timabbott
Copy link
Member

Merged, thanks @rht!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError when bridging Zulip to Element

3 participants