Ignore upcoming experimental_member_use warning #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
In an upcoming Dart SDK change (https://dart-review.googlesource.com/c/sdk/+/450970), I intend to add logic to the analyzer for generating a warning if an API marked @experimental is used. This will allow experimental analyzer features to be developed without creating a risk of breaking changes downstream. To avoid this change producing a failure in the customer_testing bot (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing), the `zulip-flutter` customer test needs to first be modified in order to ignore the upcoming warning. [greg: added comment]
Member
|
Thanks! Looks good; merging. I was curious why we're apparently using an experimental API here (news to me — which I think makes another vote in favor of the usefulness of this warning). Turns out it's fine, and I added a comment explaining why. |
gnprice
force-pushed
the
fix-upcoming-warning
branch
from
b34c240 to
e9a7288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an upcoming Dart SDK change
(https://dart-review.googlesource.com/c/sdk/+/450970), I intend to add logic to the analyzer for generating a warning if an API marked @experimental is used. This will allow experimental analyzer features to be developed without creating a risk of breaking changes downstream.
To avoid this change producing a failure in the customer_testing bot (https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing), the
zulip-fluttercustomer test needs to first be modified in order to ignore the upcoming warning.