Skip to content

Conversation

@chrisbobbe
Copy link
Collaborator

Fixes #2000.

@chrisbobbe chrisbobbe requested a review from gnprice November 20, 2025 02:33
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Nov 20, 2025
@gnprice
Copy link
Member

gnprice commented Nov 20, 2025

Thanks!

Looks like CI fails with this change:

Running pigeon...
Error: there were changes to pigeons:
 M android/app/src/main/kotlin/com/zulip/flutter/AndroidIntents.g.kt
 M android/app/src/main/kotlin/com/zulip/flutter/AndroidNotifications.g.kt
 M ios/Runner/Notifications.g.swift
 M lib/host/android_intents.g.dart
 M lib/host/android_notifications.g.dart
 M lib/host/notifications.g.dart

Fixing that with tools/check pigeon --fix --all, then I'll merge.

@gnprice gnprice force-pushed the pr-upgrade-source_gen branch from 4c147af to ed95f61 Compare November 20, 2025 05:51
@gnprice gnprice merged commit ed95f61 into zulip:main Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI broken: source_gen needs upgrade (it tries to call a method in analyzer that has been removed)

2 participants