Upgrade Flutter and packages #2009
Conversation
|
Thanks! LGTM, and looks OK with a quick manual smoke test on an iOS simulator; marking for Greg's review. |
chrisbobbe
added
the
integration review
|
Added commits with updated cocoapods and latest Flutter. (The latest Flutter version is needed for |
gnprice
left a comment
gnprice
left a comment
There was a problem hiding this comment.
Thanks @rajveermalviya for taking care of this, and @chrisbobbe for the manual testing!
Merging, after revising one commit message to clarify the questions I had in a comment below.
| ...kFallbackUserAgentHeader, | ||
| if (expectContentType) | ||
| 'content-type': 'application/x-www-form-urlencoded; charset=utf-8', | ||
| 'content-type': 'application/x-www-form-urlencoded', |
There was a problem hiding this comment.
Hmm interesting.
One breaking change which now omits `charset` parameter for all
media types except for `text` and some `application/xml` types:
https://github.com/dart-lang/http/blob/a22386e9c/pkgs/http/lib/src/request.dart#L18-L31
https://github.com/dart-lang/http/pull/1798
That breaks some of our tests which expect `charset=utf-8` being
present in the `Content-Type` header, so this commit includes a fix
for those tests, simply removing that expectation.
It looks like the upstream PR you helpfully linked to also had a similar change to tests involving application/x-www-form-urlencoded. That author explained:
NOTE: The charset parameter is not defined for application/x-www-form-urlencoded so the changes to those tests should not break anything.
and more specifically, following the link, the specified behavior for that content-type is to use UTF-8 always. So that's reassuring.
The default charset still remains `utf-8`:
https://github.com/dart-lang/http/blob/a22386e9c/pkgs/http/lib/src/request.dart#L179
I don't understand what this means, though. There's no "charset" at all now, right?
Reading the link, it looks like the point is about the encoding that gets used for generating the body.
And update Flutter's supporting libraries to match.
This commit is the result of the following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core tools/upgrade pod Changelogs: https://pub.dev/packages/firebase_core/changelog#421 https://pub.dev/packages/firebase_messaging/changelog#1604 No notable changes for both of these packages.
This commit is the result of the following commands: flutter pub upgrade --major-versions pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2612 There is one bug fix related to `InstanceManager` which seems to be used for `@ProxyApi`, which we do not use it.
Changelog: https://pub.dev/packages/http/changelog#160 One breaking change: in the Content-Type header, the `charset` parameter is no longer set automatically, except on certain types which require it. https://github.com/dart-lang/http/blob/a22386e9c/pkgs/http/lib/src/request.dart#L18-L31 dart-lang/http#1798 That breaks some of our tests which expect to see `charset=utf-8`, so this commit includes a fix for those tests, simply removing that expectation. This is OK because the content type in question is application/x-www-form-urlencoded, and that content type does not define `charset` anyway: https://www.iana.org/assignments/media-types/application/x-www-form-urlencoded In fact, it requires the use of UTF-8: https://url.spec.whatwg.org/#application/x-www-form-urlencoded The package's default encoding for actually producing the body remains UTF-8: https://github.com/dart-lang/http/blob/a22386e9c/pkgs/http/lib/src/request.dart#L179 [greg: expanded commit message]
And update Flutter's supporting libraries to match.
gnprice
force-pushed
the
pr-upgrade-flutter
branch
from
2edcb58 to
627bfd2
Compare
3 participants
Flutter notable commits
Still doesn't include a fix for #918 because even if we use the
mainbranch from upstream repo, there is another issue of a method not being implemented: james-alex/color_models#14.And same for #437, because there still doesn't seem to be support for filtering
fontentires in pubspec.yaml yet, only assets: flutter/flutter#176393.