Add "Stream settings" to HeaderActionSheet #4612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyAC
force-pushed
the
stream-settings-actionsheet-option
branch
from
ea16527 to
62c3424
Compare
This is the same thing that the (i) menu on the stream title currently displays. Since we plan to remove that icon soon, allowing people to access it here makes sense.
gnprice
force-pushed
the
stream-settings-actionsheet-option
branch
from
62c3424 to
5955c54
Compare
Member
|
LGTM, merged, thanks! |
Contributor
|
Ah, the one comment I was about to add was that it'd be good to add these new user-facing strings to static/translations/messages_en.json. (I believe we call our |
Member
|
Ah good catch, thanks! Want to push a quick change to do that? And then we should perhaps do something to make that easier to notice when writing the change in the first place. A block comment about it, at the top or bottom of the list of these options, might be a good step. |
Contributor
|
Sure, just sent #4619! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same thing that the (i) menu on the stream title currently
displays. Since we plan to remove that icon soon, allowing people to
access it here makes sense.