wip: Zulip as OAuth2 Provider #16529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aero31aero
force-pushed
the
5-oauth
branch
2 times, most recently
from
ff29d9b to
325ccbd
Compare
Right now we manually install django-oauth-toolkit.
This includes:
- help Django find the relevant templates
for the application view
- add in relevant views from the toolkit
- validate access tokens for Zulip views
TODO:
We should lock down the views and only allow admin
users to create applications, probably.
And we should automatically install the toolkit.
We should refine read/write scopes. (For now we
assume users just authorize with write scope.)
We can clean up the template-related code (to
de-duplicate the logic we use for the two-factor
templates).
And still lots else to do, like writing tests, etc.
|
Heads up @aero31aero, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Just to give a status of this:
But, overall, if anybody ever needs to take this over, they have a pretty solid foundation. It's likely to have rebase conflicts, but they will generally just be around the pip/requirements stuff. |
|
@showell can i take this PR forward? |
|
@edith007 Sure, give it a shot. |
Open
6 tasks
timabbott
force-pushed
the
main
branch
2 times, most recently
from
4ec3636 to
88b200c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #16455 with @showell.
Testing Plan:
GIFs or Screenshots: