Skip to content

Conversation

@hackerkid
Copy link
Member

@hackerkid hackerkid commented Oct 19, 2016

Fixes one issue in #1653

@hackerkid hackerkid force-pushed the avatar branch 3 times, most recently from 2fe367f to 2fb6da0 Compare October 19, 2016 23:38
@hackerkid hackerkid changed the title Add support for !avatar in echo.js Add support for !avatar and !gravatar in echo.js Oct 20, 2016
@hackerkid
Copy link
Member Author

@timabbott Please check.

@timabbott
Copy link
Member

Cool, this looks great, thanks @hackerkid! I merged this after fixing some trailing whitespace. Ideally we'd figure out a way to modify marked.js without needing to patch it, since that's definitely a maintenance liability (as a sidenote, we should probably update marked.js to a current upstream version).

@timabbott timabbott closed this Oct 20, 2016
@hackerkid
Copy link
Member Author

hackerkid commented Nov 2, 2016

@timabbott Should I follow the same approach for !_subscribe_link and !modal_link. I am not sure whether we can do this without patching marked.js.

@timabbott
Copy link
Member

Having though about this some more, I think we're going to remove !_subscribe_link as a feature; it's not that good of an experience and we just merged code to have #**StreamName** auto-link to a stream. And !modal_link is just used in the tutorial right now, so not important for local echo.

So I think we're good on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants