Skip to content

Merged DLL and improved File Selector#1

Merged
zwcloud merged 3 commits intozwcloud:masterfrom
JeReT:master
Feb 5, 2017
Merged

Merged DLL and improved File Selector#1
zwcloud merged 3 commits intozwcloud:masterfrom
JeReT:master

Conversation

@JeReT
Copy link
Copy Markdown
Contributor

@JeReT JeReT commented Feb 1, 2017

Extra-DLL not needed anymore (merged into main DLL -> leads to incompatibility with older versions of Unity).
File Selector can add / remove every folder separately and there are two buttons to expand / collapse all folders.

@zwcloud
Copy link
Copy Markdown
Owner

zwcloud commented Feb 2, 2017

Thanks for you improvement! I have tested the built dll but unfortunately it didn't work.

When I attempted to login in, an error Failed Communication always occurs
unity_2017-02-02_12-54-28
After tried many times, my account got locked temporiarily.
app_2017-02-02_12-56-24

This happened on Unity3D 5.3.0. I have had such experiences when the original AssetStoreToolsExtra.dll is replaced with the one built from my repo.

Have you tested it? I hope the issue only happens on my machine.

@JeReT
Copy link
Copy Markdown
Contributor Author

JeReT commented Feb 4, 2017

I ran it on Unity 5.5.0 and didn't run into such a problem.
I will test it again soon and also with Unity 5.3.0 to see if I can figure out something. Maybe you should log which AssetBuilder is chosen. If AssetBuilder3 is chosen then the error makes sense.

@zwcloud zwcloud merged commit e30f1c2 into zwcloud:master Feb 5, 2017
@zwcloud
Copy link
Copy Markdown
Owner

zwcloud commented Feb 5, 2017

Sorry for the late reply because I'm a little busy with another project these days.
Yes it works on Unity3D 5.4.0 and 5.5.0. The improvement looks great! Thank you! 😃
I merged the pull request but I will work on to make it work on Unity3D 5.0 and 5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants