Skip to content

Conversation

@gpap-gpap
Copy link

@gpap-gpap gpap-gpap commented Mar 9, 2023

Two minor changes:

  • added rule that replaces instances of "+ -" to "-". Not a major deal this was happening but easier for linter to understand where to break the lines like that, and,
  • changed "lambda" replacement target to "lamb" as "lambda" has special meaning in python. Potentially \[Pi] is also dangerous (i.e. maybe best keep it out of the replacement list) butI didn't want to make a design choice

@david-zwicker
Copy link
Member

Thanks for the contribution! I just saw your pull request by chance, presumably because you did not yet request a review. Unfortunately, I have a hard time reading your changes because you re-formatted the entire code. I generally like the re-formatting (how did you do this?), but it would be great if you could first re-format the code in a first commit and then apply your chances in a second commit. Alternatively, you could simply post the changes here in a comment, so I understand them better.

@david-zwicker david-zwicker self-assigned this Nov 11, 2023
@david-zwicker
Copy link
Member

I merged PR #2, which looked good. However, we now have conflicts in this branch. Could you rebase or merge the changes from the main branch into this? Manually solving the conflicts should also be fine.

@gpap-gpap
Copy link
Author

@david-zwicker should be OK now but please review because rebasing forks from upstream branches is near the limit of my git fu!!

@gpap-gpap gpap-gpap closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants