fix: resolve resource leaks, goroutine leaks, and signal handling issues#41
Merged
fix: resolve resource leaks, goroutine leaks, and signal handling issues#41
Conversation
- Fix MySQL registeredDials sync.Map entry leak by adding proper cleanup with DeregisterDialContext in close hook - Fix goroutine leak in proxy handleConnection by closing connections and waiting for io.Copy goroutines on context cancellation - Add signal handler for stdio MCP mode to enable graceful shutdown of active database connections and SSH tunnels - Add nil config check in NewToolHandler to prevent panic - Fix silent error swallowing in proxy io.Copy operations with logging - Add HTTP server timeouts and proper shutdown error handling in MCP - Fix potential race condition in closeHooks slice with mutex protection All changes pass go vet, golangci-lint, and test suite with race detector. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (62.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 81.72% 81.46% -0.27%
==========================================
Files 41 41
Lines 2933 2978 +45
==========================================
+ Hits 2397 2426 +29
- Misses 409 420 +11
- Partials 127 132 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All changes pass go vet, golangci-lint, and test suite with race detector.