Refactor resize event payload to ResizeEventArgs#34
Merged
zxyao145 merged 1 commit intoMar 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
window.onresizepayload into a single typed object to simplify event signatures and caller code.EventSlot<T1, T2>) which is no longer needed once resize uses an object.Description
ResizeEventArgsDTO withWidthandHeightproperties (src/BQuery/Dtos/ResizeEventArgs.cs).WindowEvent.OnResizemetadata to useResizeEventArgsinstead of twodoublearguments (src/BQuery/Constants/WindowEvents.cs).EventSlot<T1, T2>implementation fromBqEventsand retained the single-argumentEventSlot<T>(src/BQuery/BqEvents.cs).WindowResizewith an object payload{ width, height }and rebuilt the JS bundle (src/BQuery/wwwroot/src/module/eventHelper.ts,src/BQuery/wwwroot/bQuery.min.js).ResizeEventArgsand updated README/API docs to reflect the new signatures (Sample/BQuery.Sample.Common/Pages/Index.razor,README.md,API.md).Testing
pnpm installinsrc/BQuery/wwwrootand it completed successfully.pnpm buildinsrc/BQuery/wwwrootand the frontend bundle was built successfully producing an updatedbQuery.min.js.dotnet build /workspace/BQuery/BQuery.slnbut the command could not be executed in this environment becausedotnetis not installed.Codex Task