LS Engine upgrade, FS Engine optimizations and bugfixes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # zynthian_gui.py
you can rename your snapshots via ssh/sftp to any non-numeric name
(should there be a better way?)
+ added LSCP version checking (should be compatible with earlier versions) + reorganized channel creation/destruction sequence
reverb tails should not be modulated by chorus
+ increase timeout for 'LOAD INSTRUMENT' command + reset channel (stop all voices) before destruction
+ increase timeout for loading sound font; + add pbend/prog routers; + fix command line parameters;
Loading a new soundfont at the top of FluidSynth's soundfont stack may cause unexpected instrument change in the previously set channels. To prevent this we should reselect presets for all existing channels.
Initialize layer.ls_chan_info to None to avoid raising exceptions in the "if layer.ls.chan_info:" conditions.
Member
|
Great work, @schpion! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LS Engine have been tested with LinuxSampler 2.0.0 that was configured at compile time with following options:
./configure --enable-max-voices=21 --enable-max-streams=64 --enable-stream-min-refill=4096 --enable-refill-streams=2 --enable-stream-max-refill=131072 --enable-stream-size=262144 --disable-asm --enable-subfragment-size=64 --enable-eg-min-release-time=0.001 --enable-eg-bottom=0.0025 --enable-max-pitch=2 --enable-preload-samples=65536The FS Engine now works well with big sound fonts.