Skip to content

Fix ctrldev (bitmask) unrouting #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix ctrldev (bitmask) unrouting #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8d9e0
Fix channel routing, 0xF should be 0xFFFF
Oct 16, 2025
16fdbab
Fix routing from partially routed ctrldev device on new chains
Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion zyngine/zynthian_chain_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,10 @@ def add_chain(self, chain_id, midi_chan=None, midi_thru=False, audio_thru=False,
except Exception as e:
unroute = False
logging.warning(f"ctrldev_manager => {e}")
lib_zyncore.zmop_set_route_from(chain.zmop_index, zmip, not unroute)
if isinstance(unroute, bool) or unroute == 0xffff:
lib_zyncore.zmop_set_route_from(chain.zmop_index, zmip, not unroute)
else:
lib_zyncore.zmop_set_route_from(chain.zmop_index, zmip, True)
# Enable StepSeq MIDI intput
lib_zyncore.zmop_set_route_from(chain.zmop_index, ZMIP_STEP_INDEX, True)
# Enable SMF sequencer MIDI intput
Expand Down
4 changes: 2 additions & 2 deletions zyngine/zynthian_ctrldev_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def load_driver(self, izmip, driver_name=None):
# Unroute from chains if driver want it
if driver.unroute_from_chains:
if isinstance(driver.unroute_from_chains, bool):
lib_zyncore.zmip_set_ui_midi_chans(izmip, 0xF)
lib_zyncore.zmip_set_ui_midi_chans(izmip, 0xFFFF)
elif isinstance(driver.unroute_from_chains, int):
lib_zyncore.zmip_set_ui_midi_chans(izmip, driver.unroute_from_chains)
else:
Expand Down Expand Up @@ -199,7 +199,7 @@ def get_driver_class_name(self, izmip):
def is_input_device_available_to_chains(self, idev):
if idev in self.drivers and self.drivers[idev].unroute_from_chains:
unroute_from_chains = self.drivers[idev].unroute_from_chains
if isinstance(unroute_from_chains, bool) or unroute_from_chains == 0xF:
if isinstance(unroute_from_chains, bool) or unroute_from_chains == 0xFFFF:
return False
return True

Expand Down