Support for GROUP BY CUBE, SET, ROLLUP#383
Conversation
antonio-antuan
force-pushed
the
group_by_summarizes
branch
from
0eed550 to
850364f
Compare
|
OK so do we want this to work like "func.cube()" ? That already works now. I'm mostly thinking which ones of these do we want to keep called as "func.XYZ" and which should just be ".XYZ" - not as much for how it is implemented (they can be func in any case most likely) but how do we encourage the user to call upon them. only GROUPING SETS really needs special attention here because of the space. |
|
I'll work with it, thanks! |
|
Dear contributor - This pull request is being moved to Gerrit, at https://gerrit.sqlalchemy.org/512, where it may be tested and reviewed more closely. As such, the pull request itself is being marked "closed" or "declined", however your contribution is merely being moved to our central review system. Please register at https://gerrit.sqlalchemy.org#/register/ to send and receive comments regarding this item. |
Fixes: #3429 Co-authored-by: Mike Bayer <mike_mp@zzzcomputing.com> Change-Id: I870ee7dc801d553c5309c291402ec468b671e9a9 Pull-request: #383
https://bitbucket.org/zzzeek/sqlalchemy/issues/3429/support-for-group-by-cube-set-rollup - new funcs added - fix type into sql.elements Change-Id: I870ee7dc801d553c5309c291402ec468b671e9a9 Pull-request: #383
2 participants
https://bitbucket.org/zzzeek/sqlalchemy/issues/3429/support-for-group-by-cube-set-rollup