Support Monetary Type#395
Conversation
|
this looks very nice, thanks, will try to pull it through this week. |
|
Dear contributor - This pull request is being moved to Gerrit, at https://gerrit.sqlalchemy.org/600, where it may be tested and reviewed more closely. As such, the pull request itself is being marked "closed" or "declined", however your contribution is merely being moved to our central review system. Please register at https://gerrit.sqlalchemy.org#/register/ to send and receive comments regarding this item. |
|
|
||
| """Provide the PostgreSQL MONEY type.""" | ||
| __visit_name__ = "MONEY" | ||
| PGMacAddr = MONEY |
There was a problem hiding this comment.
At a glance this looks like it ought to be PGMoney, no?
There was a problem hiding this comment.
the whole PGSomeDataType thing is legacy, if a type is only present in Postgresql it gets the UPPERCASE type right in the postgresql dialect and that's it. here's the manifesto for the whole thing: https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/dialects/type_migration_guidelines.txt
There was a problem hiding this comment.
oh if it says PGMacAddr literally, then yes that's wrong
Change-Id: I2b40faf583a84bc5b416e1ad3aa812896ea67a8c Pull-request: #395
3 participants
PostgreSql has support monetary type since its version 8.0.