Add python_requires and update classifiers#468
Closed
hugovk wants to merge 3 commits intozzzeek:masterfrom
hugovk:update-classifiers
Closed
Add python_requires and update classifiers#468hugovk wants to merge 3 commits intozzzeek:masterfrom hugovk:update-classifiers
hugovk wants to merge 3 commits intozzzeek:masterfrom
hugovk:update-classifiers
Conversation
Owner
|
OK for version 1.3 can you also update the doc here: https://github.com/zzzeek/sqlalchemy/blame/master/doc/build/intro.rst#L74 thanks! |
Contributor
Author
|
Done, how's that? |
Owner
|
alrighty |
Owner
|
Dear contributor - This pull request is being moved to Gerrit, at https://gerrit.sqlalchemy.org/#/c/zzzeek/sqlalchemy/+/862, where it may be tested and reviewed more closely. As such, the pull request itself is being marked "closed" or "declined", however your contribution is merely being moved to our central review system. Please register at https://gerrit.sqlalchemy.org#/register/ to send and receive comments regarding this item. |
Owner
|
just tweaking a bit, thank you! |
zzzeek
pushed a commit
that referenced
this pull request
Aug 28, 2018
- bump minimum Python 3 version to 3.4 in docs - set up setup.py classifiers to cover 2.7, 3.4, 3.5, 3.6, 3.7 explicitly - add python_requires These are also the ones supported by the core Python team. https://en.wikipedia.org/wiki/CPython#Version_history Change-Id: I2ffa632c73c39bf38ba9d8b5dcc86d552b61aa68 Pull-request: #468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Adds
python_requiresto setup.py to help pip install the right version SQLAlchemy for the user's Python version.More info: https://packaging.python.org/guides/dropping-older-python-versions/
Update the classifiers to help people and tools visiting PyPI: https://pypi.org/project/SQLAlchemy/
I understand the supported versions to be 2.7 and 3.4-3.7 as per tox.ini:
envlist = py{27,34,35,36,37}-{cext,nocext}These are also the ones supported by the core Python team.
https://en.wikipedia.org/wiki/CPython#Version_history