Skip to content

Check and prevent double registration for blobbers #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2021
Merged

Check and prevent double registration for blobbers #109

merged 2 commits into from
May 17, 2021

Conversation

@andrenerd
Copy link
Contributor

@andrenerd andrenerd commented May 7, 2021

No description provided.

@andrenerd andrenerd requested a review from Sriep May 7, 2021 01:08
@andrenerd andrenerd linked an issue May 7, 2021 that may be closed by this pull request
Blobbers seem to be able to register twice #110
Closed
@andrenerd andrenerd removed a link to an issue May 7, 2021
Blobbers seem to be able to register twice #110
Closed
@andrenerd andrenerd linked an issue May 7, 2021 that may be closed by this pull request
Blobbers seem to be able to register twice #110
Closed
@guruhubb
Copy link
Member

guruhubb commented May 8, 2021

@andrenerd @Sriep I think this check needs to be on the smart contract storagesc as well.

@Sriep
Copy link
Contributor

Sriep commented May 9, 2021 •
edited
Loading

We could add a check to addBlobber. We have the new blobber and list of existing blobbers so it should easy enough to prevent duplication at this stage. Should 0chain replace and leave a warning or reject and return an error?

Issue 0chain/0chain#253 to add this.

@guruhubb
Copy link
Member

guruhubb commented May 9, 2021

@Sriep @andrenerd I think we should replace and leave a warning.

@andrenerd andrenerd mentioned this pull request May 12, 2021
Closed
@andrenerd
Copy link
Contributor Author

andrenerd commented May 12, 2021

@Sriep
please, complete the review.

the discussion about further changes in storagesc is not supposed to prevent the pr from merging.
there will be another branch/pr for that changes in the 0chain repo.

shravanshetty1
shravanshetty1 approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@shravanshetty1 shravanshetty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but it shouldnt be considered fixed until its handled on the smart contract side.
0chain/0chain#272

@Sriep Sriep merged commit bdde993 into master May 17, 2021
@Sriep Sriep deleted the feature/prevent-double-registration-for-blobbers-80 branch May 17, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sriep Sriep Awaiting requested review from Sriep

1 more reviewer

@shravanshetty1 shravanshetty1 shravanshetty1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blobbers seem to be able to register twice

5 participants

@andrenerd @guruhubb @Sriep @shravanshetty1