Skip to content

Point all old http endpoint handlers to new grpc endpoint handler #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Point all old http endpoint handlers to new grpc endpoint handler #130

wants to merge 11 commits into from

Conversation

@shravanshetty1
Copy link
Contributor

@shravanshetty1 shravanshetty1 commented May 14, 2021 •
edited
Loading

closes #68
closes #129

  • Conversion functions have been changed so that converting objects back forth will end up with objects having the same value i.e nil allocation when converted to a grpcAllocation and converted back to allocation should be nil
  • Added a few conversion functions
  • Requests should always get allocation from request context
  • Updated grpc handlers to match http handlers - [WIP] Implement signature verification #66 this pr modified http handlers
  • Pointed all http handlers to grpc handlers
  • Updated tests to account for code changes

@shravanshetty1 shravanshetty1 self-assigned this May 14, 2021
@shravanshetty1 shravanshetty1 changed the base branch from master to grpc May 17, 2021 12:37
@shravanshetty1 shravanshetty1 changed the title [WIP] Point all old http endpoint handlers to new grpc endpoint handler Point all old http endpoint handlers to new grpc endpoint handler May 17, 2021
@shravanshetty1 shravanshetty1 changed the base branch from grpc to master May 17, 2021 18:27
@shravanshetty1 shravanshetty1 changed the base branch from master to grpc May 17, 2021 18:28
@cnlangzi cnlangzi deleted the 68-http-handler-to-grpc branch February 11, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sriep Sriep Awaiting requested review from Sriep

@satchinjoshi satchinjoshi Awaiting requested review from satchinjoshi

Assignees

@shravanshetty1 shravanshetty1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add client signature in grpc request context Point all old http endpoint handlers to new grpc endpoint handler

2 participants

@shravanshetty1