[WIP] Implement signature verification #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Verifying the signature by the owner's public key should solve the problem of a fake client id. |
Sriep
reviewed
Apr 18, 2021
Contributor
Sriep
left a comment
Sriep
left a comment
There was a problem hiding this comment.
Currently blobber is not unit test friendly. The best way to mock the database needs to be considered.
…ts_authentication # Conflicts: # code/go/0chain.net/blobbercore/datastore/store.go # code/go/0chain.net/blobbercore/go.mod # code/go/0chain.net/blobbercore/go.sum
- implement MockTheStore method - remove duplicates tests methods - minor fixes
Contributor
|
What's the status of this PR and 0chain/gosdk#30 ? |
platsko
approved these changes
May 4, 2021
This was referenced May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of signature authentication for operations with allocations.
Need to be merged with additional changes on gosdk client.