Skip to content

Conversation

@shravanshetty1
Copy link
Contributor

closes #68
closes #129

  • Conversion functions have been changed so that converting objects back forth will end up with objects having the same value i.e nil allocation when converted to a grpcAllocation and converted back to allocation should be nil
  • Added a few conversion functions
  • Requests should always get allocation from request context
  • Updated grpc handlers to match http handlers - [WIP] Implement signature verification #66 this pr modified http handlers
  • Pointed all http handlers to grpc handlers
  • Updated tests to account for code changes

@shravanshetty1 shravanshetty1 requested a review from Sriep May 17, 2021 18:36
@Sriep Sriep merged commit f796055 into grpc May 19, 2021
@Sriep Sriep deleted the 68-http-to-grpc-handler-2 branch May 19, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants