Grpc migration alter generating script #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit edaeeef.
shravanshetty1
suggested changes
Apr 14, 2021
| @@ -0,0 +1,3 @@ | |||
| package blobbercore | |||
|
|
|||
| //go:generate protoc -I ./blobbergrpc/proto --go-grpc_out=. --go_out=. --grpc-gateway_out=. --openapiv2_out=./openapi ./blobbergrpc/proto/blobber.proto | |||
Contributor
There was a problem hiding this comment.
This wont work to fix issue - #44. Since go generate only works inside a go module. The directory outside blobber core .etc. is not a go module. Also make sure @guruhubb is ok with you working on this issue.
If we made the repo outside a go module there maybe complications with nested go modules since each of the sub modules use differente versions of the same dependency.
Its low prio issue i only created it to document that this needs to be done at some point. There may be other work thats more prio right now.
Contributor
|
Closing this as it does seem useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing script on
go generate.