chore(cookie): simplify getter methods by removing inline attributes

[0x676e67]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the cookie module by simplifying its getter methods and improving code style. The core intent is to remove explicit #[inline] attributes from Cookie struct getters, trusting the compiler's optimization capabilities, and to make a minor stylistic improvement to the Jar's clear method. These changes contribute to cleaner, potentially more maintainable code without altering functionality.

Highlights

• Getter Method Simplification: The #[inline] attribute has been removed from all getter methods within the Cookie struct, such as name, value, http_only, and expires. This change allows the Rust compiler to apply its default inlining heuristics, potentially simplifying the code and relying on the compiler's optimization decisions.
• Code Style Refinement: The clear method in the Jar implementation has been refactored for conciseness, simplifying the closure syntax by removing unnecessary curly braces and a semicolon.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies some code in src/cookie.rs by removing #[inline] attributes from getter methods and simplifying a closure. While the simplifications are generally good for readability, removing #[inline] from public functions in a library can have performance implications for downstream Rust crates due to lack of cross-crate inlining. I've left a comment suggesting to reconsider this change to ensure optimal performance for all consumers of the library. The other changes look good.