Fix schema-controlled storage path safety - #122
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0311653428
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ad552733c
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
SchemaStoragePathabstraction for schema-controlled filesystem accessREQ-aps-cli-027andREQ-state-store-020Root cause
Schema validation previously used string checks and destructive operations appended the schema path directly to the state root. An
EncryptedFilepath of.could therefore resolve to the root itself, andkey remove --purgecould recursively delete it.User impact
Invalid or dangerous storage paths now fail during registration/schema load and again at operation time. Valid nested paths continue to round-trip. The original root-deletion attack is covered in Unix and PowerShell smoke contracts with a sentinel file.
Test plan
specsync change verifypasses with 100% ownership coveragefledge trust verifypasses after the Linux XCTest compatibility fix; Augur verdictproceed, risk 30Closes #111