Update: prepare aps 1.1.0 release - #135
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d973971c3
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ./Scripts/prepare-version.py --check | ||
| test "$RELEASE_TAG" = "v$(cat VERSION)" |
There was a problem hiding this comment.
On a manual backfill of any release predating this commit, the test job checks out the historical tag and then immediately invokes Scripts/prepare-version.py and reads VERSION, neither of which exists in those commits, so the workflow fails before testing or building. This breaks the historical-tag backfill promised by REQ-aps-cli-036; condition this source-contract check on its availability or perform the tag/version validation without requiring newly added files from the historical checkout.
AGENTS.md reference: AGENTS.md:L125-L127
Useful? React with 馃憤聽/ 馃憥.
| echo "macos_aarch64=$(validate "$(fetch aps-macos-aarch64)")" | ||
| echo "macos_x86_64=$(validate "$(fetch aps-macos-x86_64)")" | ||
| echo "linux_x86_64=$(validate "$(fetch aps-linux-x86_64)")" | ||
| echo "linux_x86_64=$(validate "$(fetch aps-linux-x86_64-portable.tar.gz)")" |
There was a problem hiding this comment.
When manually dispatching this recovery workflow for the advertised v1.0.0 example, this download now requests aps-linux-x86_64-portable.tar.gz.sha256, but the repository documents that v1.0.0 predates and does not contain the portable bundle. The fetch therefore fails before the formula can be resynchronized; select the legacy Linux asset and install layout for older tags, or explicitly restrict the recovery workflow to portable-bundle releases.
Useful? React with 馃憤聽/ 馃憥.
| perl -pi -e 's/const productVersion = "1\.1\.0"/const productVersion = "9.9.9"/' \ | ||
| "$temporary_root/site/app/page.tsx" |
There was a problem hiding this comment.
When preparing the next release with prepare-version.py --set (for example, 1.2.0), this hard-coded substitution no longer matches page.tsx, so the intended drift mutation is a no-op and the following --check succeeds, causing the version-contract test itself to fail. This makes the advertised single version-preparation command require a manual test-script edit for every future version; derive the matched current value from VERSION or replace the captured version generically.
AGENTS.md reference: AGENTS.md:L125-L127
Useful? React with 馃憤聽/ 馃憥.
1 participant
Summary
0xLeif/0xdesign system withtofu-ux/0xupstream attributionCloses #115
Closes #116
Closes #117
Test Plan
fledge lanes run verify(11 steps)specsync change verifyand strict acceptanceaugur check --range origin/main...HEAD --no-coverage(REVIEW, 37/100; not blocked)attest verify --range origin/main...HEADnpm run lint,npm run build:pages,npm run test:a11y, andnpm testinsite/fledge release 1.1.0 --no-bump --dry-runtargets v1.1.0Notes
The broad diff is intentional: this is the single release-preparation PR requested for v1.1.0, including release distribution, version consistency, documentation, and the site design-system integration.