feat(block-producer): increase and make max txs per batch and batches per block configurable via CLI#1015
Merged
Mirko-von-Leipzig merged 9 commits into0xMiden:nextfrom Jul 3, 2025
Conversation
Contributor
Author
|
Hi, just let you know this PR ready to review @Mirko-von-Leipzig |
Mirko-von-Leipzig
approved these changes
Jun 27, 2025
Mirko-von-Leipzig
requested changes
Jun 27, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Some minor recommendations but otherwise LGTM
Contributor
Author
|
i applied the suggestion @Mirko-von-Leipzig , do i need to resolve the conflict too? |
Mirko-von-Leipzig
requested changes
Jun 27, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
If you could resolve the conflicts, that would be great. If not I can do it a bit later as well.
Comment on lines
+128
to
+72
| anyhow::bail!( | ||
| "max-txs-per-batch ({}) cannot exceed protocol limit ({})", | ||
| max_txs_per_batch, | ||
| miden_objects::MAX_ACCOUNTS_PER_BATCH | ||
| ); |
Collaborator
There was a problem hiding this comment.
Apologies, I didn't mark this earlier, but could you also do the same here?
farrellh1
force-pushed
the
feature-configurable-batch-block-limits
branch
from
96a662f to
1c97f0b
Compare
Contributor
Author
|
i think we should i have a make script for installing some dependencies especially for the linting what do you think @Mirko-von-Leipzig ? btw i resolved the conflict |
…nfigurable via CLI
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
farrellh1
force-pushed
the
feature-configurable-batch-block-limits
branch
from
a79e069 to
da7d3a9
Compare
Mirko-von-Leipzig
approved these changes
Jul 3, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Thank you; and sorry for the delay!
bobbinth
reviewed
Jul 5, 2025
bobbinth
reviewed
Jul 5, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--max-txs-per-batch) and the maximum number of batches per block (--max-batches-per-block) for both standalone and bundled node modes.