fix: matching fields in GetMetadataResponse from the faucet#1918
Merged
fix: matching fields in GetMetadataResponse from the faucet#1918
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-fix-issuance-field
branch
from
ac62d51 to
83e7846
Compare
sergerad
reviewed
Apr 9, 2026
|
|
||
| ## v0.14.5 (2026-04-10) | ||
|
|
||
| - Removed `issuance` field from the network monitor's faucet `GetMetadataResponse` ([#1918](https://github.com/0xMiden/node/pull/1918)). |
Collaborator
There was a problem hiding this comment.
Remember to update Cargo.toml version to 0.14.5 also. I tend to forget, need some automation to catch it maybe.
sergerad
approved these changes
Apr 9, 2026
Collaborator
sergerad
left a comment
sergerad
left a comment
There was a problem hiding this comment.
LGTM just remember to update version in Cargo.toml
igamigo
approved these changes
Apr 9, 2026
Comment on lines
62
to
72
| /// Response from the faucet's `/get_metadata` endpoint. | ||
| #[derive(Clone, Debug, Serialize, Deserialize)] | ||
| pub struct GetMetadataResponse { | ||
| version: String, | ||
| id: String, | ||
| issuance: u64, | ||
| max_supply: u64, | ||
| decimals: u8, | ||
| explorer_url: Option<String>, | ||
| pow_load_difficulty: u64, | ||
| base_amount: u64, | ||
| } |
Collaborator
There was a problem hiding this comment.
How is the error message for serde errors propagated for this? I think we got
Failed to parse metadata response: {"version":"0.14.0","id":"mdev1aqt0djza2efvjgqg0y29hlw6jvn93r0a","max_supply":100000000000000000,"decimals":6,"explorer_url":null,"pow_load_difficulty":65536,"base_amount":100000000}
But maybe we could have emitted a more specific one ("expected field decimals").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently a mismatch in the response from the faucet was detected, and it was caused by the removal of the issuance field from the
GetMetadataResponse. This PR fixes it by removing the field.