Skip to content

fix: matching fields in GetMetadataResponse from the faucet #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobbinth merged 2 commits into from
Apr 10, 2026
+4 −5
Merged

fix: matching fields in GetMetadataResponse from the faucet #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83e7846
fix: matching fields in GetMetadataResponse from the faucet
SantiagoPittella Apr 9, 2026
af71d7f
Merge branch 'main' into santiagopittella-fix-issuance-field
bobbinth Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v0.14.5 (2026-04-10)

- Removed `issuance` field from the network monitor's faucet `GetMetadataResponse` ([#1918](https://github.com/0xMiden/node/pull/1918)).
Copy link
Copy Markdown
Collaborator

@sergerad sergerad Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update Cargo.toml version to 0.14.5 also. I tend to forget, need some automation to catch it maybe.


## v0.14.4 (2026-04-08)

- Added missing `AuthControlled::allow_all()` mint policy component to genesis faucet accounts ([#1903](https://github.com/0xMiden/node/pull/1903)).
Expand Down
4 changes: 0 additions & 4 deletions bin/network-monitor/assets/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,10 +554,6 @@ function updateDisplay() {
<span class="metric-label">Version:</span>
<span class="metric-value">${details.FaucetTest.faucet_metadata.version || '-'}</span>
</div>
<div class="metric-row">
<span class="metric-label">Current Issuance:</span>
<span class="metric-value">${details.FaucetTest.faucet_metadata.issuance.toLocaleString()}</span>
</div>
<div class="metric-row">
<span class="metric-label">Max Supply:</span>
<span class="metric-value">${details.FaucetTest.faucet_metadata.max_supply.toLocaleString()}</span>
Expand Down
1 change: 0 additions & 1 deletion bin/network-monitor/src/faucet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ struct GetTokensResponse {
pub struct GetMetadataResponse {
version: String,
id: String,
issuance: u64,
max_supply: u64,
decimals: u8,
explorer_url: Option<String>,
Expand Down
Loading