Skip to content

feat(ntx): implement RPC client#2162

Merged
igamigo merged 7 commits into
nextfrom
igamigo-export-ntxauth
Jun 1, 2026
Merged

feat(ntx): implement RPC client#2162
igamigo merged 7 commits into
nextfrom
igamigo-export-ntxauth

Conversation

@igamigo
Copy link
Copy Markdown
Collaborator

@igamigo igamigo commented May 29, 2026

While testing 0xMiden/miden-client#2203, I realized we needed NtxAuth exported for bootstrapping the testing node easily, so I made that change in this branch. <- (this change was removed in favor of using the node binaries directly)
When testing that implementation, noticed the NTX-related tests were failing so looking into it I realized the RPC client was missing, so I made a first implementation. Opening as draft because client integration tests are still not passing.

@Mirko-von-Leipzig Mirko-von-Leipzig changed the title feat(ntx): export NtxAuth and implement RPC clien feat(ntx): export NtxAuth and implement RPC client May 30, 2026
Comment thread crates/rpc/src/lib.rs Outdated
Base automatically changed from santiagopittella-ntx-builder-block-sub-phase-3 to next May 30, 2026 07:17
@igamigo igamigo force-pushed the igamigo-export-ntxauth branch from c5c7483 to 0c1f920 Compare May 30, 2026 16:00
@igamigo
Copy link
Copy Markdown
Collaborator Author

igamigo commented May 30, 2026

client integration tests are still not passing.

What was missing here was adding the genesis commitment to the RPC client's accept header settings.

I'm not quite following the flow here - do you manually submit ntx yourselves to get things into a certain state?

From before, we were manually setting up the processes for our testing node, which allowed us to configure various things (haven't looked at migrating to the docker setup). Now, for starting the RPC process we need to set the ntx auth headers which requires that struct if we want to do it in Rust:

            Rpc {
                listener: grpc_rpc,
                ...
                network_tx_auth: Some(NetworkTxAuth(ntx_auth_header)),
            }

@igamigo igamigo marked this pull request as ready for review June 1, 2026 11:16
Comment thread bin/ntx-builder/src/db/migrations/001_initial.sql Outdated
@igamigo igamigo changed the title feat(ntx): export NtxAuth and implement RPC client feat(ntx): implement RPC client Jun 1, 2026
@igamigo
Copy link
Copy Markdown
Collaborator Author

igamigo commented Jun 1, 2026

I removed the NtxAuth re-export and will refactor the client to use the binaries. It'll look a bit hacky especially at first but we can improve the setup later (already have a working PoC). If all else fails, I'll fall back to re-exporting the struct and using that

@igamigo igamigo merged commit 1f55f20 into next Jun 1, 2026
20 checks passed
@igamigo igamigo deleted the igamigo-export-ntxauth branch June 1, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants