chore: use local data for ntx builder datastore impl#2166
Closed
SantiagoPittella wants to merge 3 commits into
Closed
chore: use local data for ntx builder datastore impl#2166SantiagoPittella wants to merge 3 commits into
SantiagoPittella wants to merge 3 commits into
Conversation
SantiagoPittella
added
the
no changelog
Collaborator
There was a problem hiding this comment.
Do we need RPC for FPI?
Collaborator
Author
There was a problem hiding this comment.
Yes, because it can be a non-network account, and we need the global inclusion proof
Collaborator
There was a problem hiding this comment.
Sorry I meant are the methods below not for FPI at all?
| ))); | ||
| } | ||
|
|
||
| let vault = self.account.vault(); |
Collaborator
There was a problem hiding this comment.
Should we check the vault root here?
Collaborator
There was a problem hiding this comment.
Sorry I meant are the methods below not for FPI at all?
Collaborator
Author
|
Closing in favor of #2162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will delete the RPC part after #2162 gets merged.
This moves the DataStore implementation for the ntx builder to be local-first