fix(monitor): store counter on wallet account#2293
Merged
Mirko-von-Leipzig merged 1 commit intoJun 29, 2026
Conversation
1dfa960 to
60eb4e7
Compare
Mirko-von-Leipzig
approved these changes
Jun 29, 2026
Mirko-von-Leipzig
left a comment
Collaborator
There was a problem hiding this comment.
Ah yeah I'd seen that before a few times back when testnet crash looped.
Nice fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After running a benchmarks against
devnetI noticed something off in the network monitor's counter: it was being properly increased by with a constant difference between the expected and the actual value of 7.This was weird because usually it should catch up or not increase at all, and the cards was stuck as unhealthy (at the time of opening the PR it is still marked as unhealthy). We have some mechanisms to fix counter issues on runtime but, after some time debugging, I realized what happened:
To avoid this for happening in the future, this PR adds a counter in the wallet's storage as a new slot. This way we ensure that if the tx succeeds the counter is increased and the network note was truly created.
Changelog