Skip to content

chore: Remove remote prover client crate#2315

Merged
sergerad merged 5 commits into
nextfrom
sergerad-rm-remote-prover-client-crate
Jul 6, 2026
Merged

chore: Remove remote prover client crate#2315
sergerad merged 5 commits into
nextfrom
sergerad-rm-remote-prover-client-crate

Conversation

@sergerad

@sergerad sergerad commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the miden-remote-prover-client crate and adds thin wrapper clients where necessary:

  1. RemoteBlockProvercrates/block-producer/src/block_prover.rs

  2. RemoteBatchProvercrates/block-producer/src/batch_builder/remote_prover.rs

  3. RemoteTransactionProverbin/ntx-builder/src/clients/prover.rs

  4. RemoteTransactionProverbin/benchmark/src/prover.rs

Closes #995.

Changelog

[[entry]]
scope       = "prover"
impact      = "removed"
description = "Removed the miden-remote-prover-client crate"

@kkovaacs kkovaacs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: now that the prover client is gone can we maybe remove the following line from rust-toolchain.toml?

targets    = ["wasm32-unknown-unknown"]

Other than that this looks good to me, thanks!

@SantiagoPittella SantiagoPittella left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to coordinate with the client since we are switching to node's next branch and this will break it. cc @igamigo @juan518munoz

@igamigo

igamigo commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Looks good. We need to coordinate with the client since we are switching to node's next branch and this will break it. cc @igamigo @juan518munoz

Yeah, was keeping this in mind (similarly in the faucet BTW). I think it will be simple to replace as the protobuf definitions are already shipped through the same crate as the others, so it's just generating a client in the same way we generate one for the RPC API. But to be clear, the version we are migrating to will not contain these changes yet.

@sergerad
sergerad enabled auto-merge (squash) July 6, 2026 21:12
@sergerad
sergerad merged commit c0b785d into next Jul 6, 2026
24 checks passed
@sergerad
sergerad deleted the sergerad-rm-remote-prover-client-crate branch July 6, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge miden-proving-service and miden-proving-service-client

4 participants