chore: Remove remote prover client crate#2315
Conversation
kkovaacs
left a comment
There was a problem hiding this comment.
Nit: now that the prover client is gone can we maybe remove the following line from rust-toolchain.toml?
targets = ["wasm32-unknown-unknown"]Other than that this looks good to me, thanks!
SantiagoPittella
left a comment
There was a problem hiding this comment.
Looks good. We need to coordinate with the client since we are switching to node's next branch and this will break it. cc @igamigo @juan518munoz
Yeah, was keeping this in mind (similarly in the faucet BTW). I think it will be simple to replace as the protobuf definitions are already shipped through the same crate as the others, so it's just generating a client in the same way we generate one for the RPC API. But to be clear, the version we are migrating to will not contain these changes yet. |
Summary
Removes the
miden-remote-prover-clientcrate and adds thin wrapper clients where necessary:RemoteBlockProver—crates/block-producer/src/block_prover.rsRemoteBatchProver—crates/block-producer/src/batch_builder/remote_prover.rsRemoteTransactionProver—bin/ntx-builder/src/clients/prover.rsRemoteTransactionProver—bin/benchmark/src/prover.rsCloses #995.
Changelog