chore: upgrade vm & crypto#2320
Merged
Merged
Conversation
juan518munoz
marked this pull request as ready for review
July 7, 2026 19:47
sergerad
reviewed
Jul 7, 2026
sergerad
approved these changes
Jul 7, 2026
sergerad
left a comment
sergerad
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I'm unfamiliar with the MASM and AccountId changes. Also the RocksDbStorage will be removed soon so its not super important.
igamigo
approved these changes
Jul 8, 2026
igamigo
left a comment
igamigo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Left some minor comments. Feel free to disregard the nits if you prefer the current approaches.
SantiagoPittella
approved these changes
Jul 8, 2026
kkovaacs
approved these changes
Jul 9, 2026
kkovaacs
left a comment
kkovaacs
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me apart from a small nit wrt CHANGELOG.md.
Mirko-von-Leipzig
approved these changes
Jul 9, 2026
|
|
||
| #[cfg(feature = "rocksdb")] | ||
| use miden_large_smt_backend_rocksdb::RocksDbStorage; | ||
| use miden_crypto::merkle::smt::RocksDbStorage; |
Collaborator
There was a problem hiding this comment.
@kkovaacs we should probably remove the rocksdb feature?
Mirko-von-Leipzig
force-pushed
the
jmunoz-update-miden-vm
branch
from
July 9, 2026 13:44
bb5c2b7 to
243b806
Compare
Mirko-von-Leipzig
enabled auto-merge (squash)
July 9, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #2282
Upgrades
miden-vmandmiden-cryptoto its latest versions.Changelog