feat(logging): add account, note, storage, and mempool lifecycle events - #2358
Merged
Conversation
Log lines are now emitted for mempool lifetime events.
apply_block() now logs detailed lifecycle events for all relevant objects in the block that has been applied.
sergerad
reviewed
Jul 21, 2026
sergerad
reviewed
Jul 21, 2026
sergerad
reviewed
Jul 21, 2026
sergerad
reviewed
Jul 21, 2026
sergerad
reviewed
Jul 21, 2026
…e-events # Conflicts: # crates/store/src/db/mod.rs # crates/store/src/state/apply_block.rs
Mirko-von-Leipzig
approved these changes
Jul 27, 2026
Comment on lines
+628
to
+633
| tracing::warn!( | ||
| target: COMPONENT, | ||
| %err, | ||
| nullifiers.count = chunk.len(), | ||
| "Failed to resolve consumed note IDs for lifecycle events", | ||
| ); |
Collaborator
There was a problem hiding this comment.
When would this happen?
Collaborator
Author
There was a problem hiding this comment.
This is specifically for unauthenticated notes that don't have their nullifier in our DB. Maybe this should not even be a warning, because unauthenticated notes created and consumed in the same block would trigger this?
Collaborator
There was a problem hiding this comment.
I'm a bit concerned about how this will scale when we want to change how things work in the mempool.
But I guess we'll have to cross that bridge when we get there.
Otherwise the prover crate litters the logs with INFO level events.
sergerad
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves part 2 of issue #2330
Changelog