chore: update protocol - #2421
Merged
Merged
Conversation
juan518munoz
marked this pull request as ready for review
August 3, 2026 17:26
igamigo
force-pushed
the
jmunoz-update-protocol
branch
2 times, most recently
from
August 6, 2026 21:11
4d200d2 to
d860a71
Compare
igamigo
reviewed
Aug 6, 2026
Collaborator
There was a problem hiding this comment.
(Sorry I accidentally force pushed to this branch!)
LGTM! I left some comments. Overall I believe we could merge this if we address the remaining comments, and we can prove the monitor works. The latter will need a refactor to handle non-zero fees soon, so maybe we can rework it more deeply there, not sure. Additionally, tagged @SantiagoPittella to see what his opinion is there.
SantiagoPittella
approved these changes
Aug 6, 2026
igamigo
approved these changes
Aug 7, 2026
igamigo
left a comment
igamigo
left a comment
Collaborator
There was a problem hiding this comment.
I was also able to test the monitor and saw it works well. LGTM!
Mirko-von-Leipzig
approved these changes
Aug 7, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR does not work for chains which base fee is not zero (e.g network monitor and benchark binaries are only able to operate with fee-less chains). Full fee implementation is left as a follow-up PR.
Changelog