chore(network-monitor): add new NTL stats to monitor - #2521
Merged
Conversation
Collaborator
There was a problem hiding this comment.
Some backwards compatibility baked in here; not sure we need it.
Mirko-von-Leipzig
approved these changes
Aug 27, 2026
igamigo
approved these changes
Aug 28, 2026
Comment on lines
+72
to
+74
| // Stats enrich the card but do not decide health: a deployment that predates the | ||
| // Stats RPC (or a transient stats failure) must not flip a serving service to | ||
| // unhealthy. |
Collaborator
There was a problem hiding this comment.
I think if the NTL does not respond to this call we should mark it as unhealthy (and so no need to keep it backward-compatible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the NTL status card with data from the NTL Stats RPC (
v0.5.0-rc.2): version, total notes, total tags, and last note activity.Changelog