Gate Gemini image cassette tests on image feature - #2007
Merged
Conversation
This was referenced Jul 4, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(feature = "image")].cargo test -p rig --tests --no-run.--all-featuresgraph and missing root integration-test compile failures when optional features are disabled.Why CI passed before
cargo nextest run --all-features --retries 2.--all-featuresbecause theimagefeature was enabled, sorig::image_generation,ImageGenerationClient, andGEMINI_2_5_FLASH_IMAGEexisted.cargo testuses the default feature set, whereimageis disabled; the ungated Gemini image-generation test module still compiled and referenced image-only APIs, causing the failure.Validation
cargo fmt --checkcargo test -p rig --tests --no-runcargo test -p rig --test gemini -- --nocapture --test-threads=1cargo test -p rig --all-features --test gemini image_generation -- --nocapture --test-threads=1cargo clippy --all-targets --all-featurescargo testwas also run. The prior Gemini image-generation compile failure is fixed; the run later fails on an unrelated existing OpenAI cassette replay mismatch inopenai::cassette::permission_control::permission_control_streaming_example.Notes